fix(testing): add think_causally + ThinkCategory.CAUSAL_ANALYSIS — fix broken test_causal_reasoning.py (#4729)#4735
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 15, 2026
Merged
Conversation
#4729) Add CAUSAL_ANALYSIS to ThinkCategory enum and think_causally() convenience function to agent_loop/think_tool.py; fix _extract_root_cause to prefer conclusion over reasoning for root cause extraction; mark integration test xfail where llama_index optional dep is absent.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4729
Summary
ThinkCategory.CAUSAL_ANALYSISto the enum inagent_loop/types.pythink_causally()convenience function toagent_loop/think_tool.pyalongside existingthink_before_gitetc., withCAUSAL_ANALYSISpromptCausalErrorAnalyzer._parse_causal_resultto usethink_result.conclusionfirst (the ThinkTool's explicit summary), falling back to reasoning only when conclusion is emptyTestCausalReasoningIntegration::test_intelligent_agent_causal_promptmarked@pytest.mark.xfail— requiresllama_indexwhich is not installed in the test environment (matches existing pattern)Tests
🤖 Generated with Claude Code