fix(knowledge): set _running=True during loop execution so re-init guard is effective (#4937)#4962
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 17, 2026
Merged
fix(knowledge): set _running=True during loop execution so re-init guard is effective (#4937)#4962mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…ard is effective (#4937) Set self._running = True at the start of run_once() and reset it to False in a finally block, so the get_loop_orchestrator() singleton guard added in #4917 correctly prevents replacing an in-flight orchestrator. Add 5 tests covering _running lifecycle and singleton guard behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4937
Summary
_runningflag was never set toTrue, making theget_loop_orchestrator()guard from bug(knowledge): get_loop_orchestrator re-init discards running loop — orphaned task if _running=True during replacement #4917 always ineffectiverun_once()now setsself._running = Trueimmediately before the run and resets toFalsein afinallyblockget_loop_orchestrator()now correctly returns the existing singleton when a run is activeTests