fix(knowledge): propagate dep_error so missing tree-sitter counts as failed not skipped (#4938)#4970
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 17, 2026
Merged
fix(knowledge): propagate dep_error so missing tree-sitter counts as failed not skipped (#4938)#4970mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…itter is counted as failed not skipped (#4938) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4938
Summary
extract_python/extract_javascriptreturned{'nodes': [], 'edges': []}on ImportError —index_filecounted the file asskippedwith no diagnosticdep_errorkey to extractor's ImportError return valueindex_filenow checks fordep_errorand recordsfailed += 1with descriptive messageTests
test_index_file_dep_error_counts_as_failed— patches extractor, assertsfailed=1, skipped=0and error contains "missing dependency"