fix(agent_loop): bridge APPROVAL_REQUIRED events to LiveEventManager for frontend dialog (#4959)#4974
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 17, 2026
Merged
fix(agent_loop): bridge APPROVAL_REQUIRED events to LiveEventManager for frontend dialog (#4959)#4974mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…for frontend dialog (#4959) RedisEventStreamManager (agent_loop) and LiveEventManager (WebSocket/frontend) are two disconnected event buses. After publishing APPROVAL_REQUIRED to the Redis bus, also call publish_live_event("global", "tool_approval_required", ...) so the WebSocket layer receives the event and the frontend approval dialog fires.
mrveiss
added a commit
that referenced
this pull request
Apr 17, 2026
…se (#5014, #4959) PR #4974 bridged tool-approval events to LiveEventManager using the lowercase literal "tool_approval_required", but the frontend filter expects "APPROVAL_REQUIRED". Result: the bridged event was silently dropped and the approval dialog never fired despite #4959 appearing fixed. Align by importing EVT_APPROVAL_REQUIRED from the new events.event_types module. Closes #5014. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4959
Summary
publish_live_event("global", "tool_approval_required", {...})call in_request_approval()inagent_loop/loop.pyimmediately after the existingRedisEventStreamManagerpublishapproval_id,tool_name,arguments,reason,risk_level,timeout_seconds,task_idTest Status
PASS — py_compile clean on loop.py and live_event_manager.py