Skip to content

Fix dimensions in week08 homework #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix dimensions in week08 homework #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions week08_inference_software/homework.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@
"metadata": {},
"outputs": [],
"source": [
"input_shape = 1, 32, 64, 64\n",
"input_shape = (1, 32, 64, 64)\n",
"num_groups = 8\n",
"test_group_norm(input_shape, num_groups, torch.float16)"
]
Expand All @@ -380,8 +380,8 @@
"source": [
"# You need to check your implementation for the following parameters\n",
"batch_size = 2\n",
"for image_resolution in [32, 128, 512, 1024, 2048, 4096]:\n",
" for num_channels in [32, 128, 512, 1024]:\n",
"for image_resolution in [32, 128, 512, 1024, 1536, 2048]:\n",
" for num_channels in [32, 128, 386, 512]:\n",
" for num_groups in [1, 4, 8, 16, 32]:\n",
"\n",
" dummy_input = torch.randn(batch_size, num_channels, image_resolution, image_resolution)\n",
Expand Down