typing(strict): repositories batch 3 (no API/UI changes)#27
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔒 Privacy Audit ResultsPrivacy Audit ReportDate: 2025-09-21 17:26:05 Summary
✅ No violations found! Coverage
📎 View detailed report |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
msaedi
force-pushed
the
typing-strict/repositories-batch3
branch
from
5cea14b to
820c96b
Compare
|
Env-contract (API-only) evidence — run https://github.com/msaedi/instructly/actions/runs/17896890686\n- [headers] X-Site-Mode=preview X-Phase=instructor_only\n- [cors] access-control-allow-credentials=true access-control-allow-origin=https://preview.instainstru.com\n- [429-triage] dedupeKey=env-contract:rate-limit-test limited=7 attempts=10\n- [headers] X-Site-Mode=prod X-Phase=instructor_only\n- [cors] access-control-allow-credentials=true access-control-allow-origin=https://beta.instainstru.com\n- [429-triage] dedupeKey=env-contract:rate-limit-test limited=7 attempts=10 |
|
Post-merge guardrails (main):\n- Env-contract (preview/beta API-only): https://github.com/msaedi/instructly/actions/runs/17896946218\n - [headers] X-Site-Mode=preview X-Phase=instructor_only\n - [cors] access-control-allow-credentials=true access-control-allow-origin=https://preview.instainstru.com\n - [429-triage] dedupeKey=env-contract:rate-limit-test limited=7 attempts=10\n - [headers] X-Site-Mode=prod X-Phase=instructor_only\n - [cors] access-control-allow-credentials=true access-control-allow-origin=https://beta.instainstru.com\n - [429-triage] dedupeKey=env-contract:rate-limit-test limited=7 attempts=10\n- Schemathesis (target=all): https://github.com/msaedi/instructly/actions/runs/17896989364\n - [schemathesis-preview] total=0 passed=0 failures=0 errors=0\n - [schemathesis-beta] total=0 passed=0 failures=0 errors=0 |
…6,37,38) Platform launch gate: - Replace hardcoded date gate on Public Profile with student_launch_enabled platform config flag, default false (#5) - Exposed through /api/v1/config/public, read-only in this pass Tab indicators: - Standardize all tab indicators to text-width across platform (#27) - Shared textWidthTabs helper, applied to Bookings + Earnings tabs Booking status consistency: - Completed badge → blue everywhere: list cards, detail page, modal (#28) - Shared bookingStatus helper for badge color standard (Confirmed=green, Completed=blue, Cancelled=red) - Empty states for Upcoming + Past booking tabs (#29) Messages fixes: - "Last updated manually" → actual timestamp or hidden (#36) - "NEXT BOOKING" → sentence case "Next booking" (#37) - Upcoming badge → green (matches Confirmed standard) - Booking cards in dropdown are now clickable links Left nav: - Reordered: Dashboard, Bookings, Messages, Availability, Referrals, Reviews, Instructor Profile, Account (#38) - Messages added as route link with MessageSquare icon - Shared nav config drives both desktop and mobile Verify: 13,198 backend + 392 frontend tests passing.
…design (#339) * feat(dashboard): A-Team quick wins Part 1 — 12 UI fixes (#1,6,7,10,12,14,15,17,19,20,21,22,23) Icons and visual cleanup: - Replace confetti emoji with Lucide Rocket on Go Live button (#1) - Replace crooked star with Phosphor Star on Reviews card (#6) - Proportional star fill based on rating, inline "4.5★ (3)" metadata (#7) - Add @phosphor-icons/react dependency Account settings overhaul: - Single-open accordion — only one section expanded at a time (#14) - Section icons: UserRoundPen (Account), SlidersHorizontal (Prefs), Info (About) (#21) - Remove Acknowledgments from About, rename support label (#20) - Remove phone management block from Preferences (#17) - Format phone display as (212) 555-1001 in Account Details (#10) - Shared formatPhoneDisplay helper in lib/phone.ts - 2FA state refreshes immediately after enable/disable (#12) 2FA modal copy: - Title → "Connect your authenticator app" (#15) - Step 1/Step 2 labels, button → "Verify" Notification preferences: - Isolate per-toggle pendi single toggle change no longer flashes entire Push column (#19) Instructor profile: - Remove Personal Information accordion from dashboard context (#22) - Skills & Pricing icon → Phosphor Tag (#23) Verify: 13,194 backend + 389 frontend tests passing. * feat(dashboard): A-Team quick wins Part 2 — 8 UI fixes (#5,27,28,29,36,37,38) Platform launch gate: - Replace hardcoded date gate on Public Profile with student_launch_enabled platform config flag, default false (#5) - Exposed through /api/v1/config/public, read-only in this pass Tab indicators: - Standardize all tab indicators to text-width across platform (#27) - Shared textWidthTabs helper, applied to Bookings + Earnings tabs Booking status consistency: - Completed badge → blue everywhere: list cards, detail page, modal (#28) - Shared bookingStatus helper for badge color standard (Confirmed=green, Completed=blue, Cancelled=red) - Empty states for Upcoming + Past booking tabs (#29) Messages fixes: - "Last updated manually" → actual timestamp or hidden (#36) - "NEXT BOOKING" → sentence case "Next booking" (#37) - Upcoming badge → green (matches Confirmed standard) - Booking cards in dropdown are now clickable links Left nav: - Reordered: Dashboard, Bookings, Messages, Availability, Referrals, Reviews, Instructor Profile, Account (#38) - Messages added as route link with MessageSquare icon - Shared nav config drives both desktop and mobile Verify: 13,198 backend + 392 frontend tests passing. * fix(dashboard): address testing feedback on quick wins branch Fixes from manual testing: - Restore two-line empty state format: bold heading + muted subtitle in dashed card (Upcoming + Past booking tabs) - Remove MessageSquare icon from Messages nav item (text-only like others) - Public Profile button: environment-aware — always enabled on preview/localhost, gated by student_launch_enabled on beta hosts only - 2FA: redirect to /login after disable (immediate) and after enable (after backup codes acknowledgment) to prevent stale session UI - Account Details: split Name into First name + Last name (locked), inline phone verification with Verified/Verify/Pending states - Update e2e tests for new reviews card DOM (reviews-summary testid)
1 participant
Summary
Testing
Refs #20