Skip to content

Conversation

@skondratov
Copy link

Currently mpu.exe ignores internal types.
This feature introduces new argument '--admit-non-public-types', which can be used to make generator to consider non-public types.

@yfakariya
Copy link
Member

Thank you for contribution, and it looks good to me.

But I have a question. As I answered in #226, the generated code or assembly should not work unless:

  • The assembly will be friend assembly of the target type's assembly.
  • The source code will be included in the target type's assembly.

Did you consider them?

@yfakariya yfakariya added the enhancement Requires or request to feature enhancement label Apr 11, 2017
@skondratov
Copy link
Author

skondratov commented Apr 12, 2017

Hi @yfakariya,

The assembly will be friend assembly of the target type's assembly.
The source code will be included in the target type's assembly.

As any other internal functionality, i guess. Or may be i miss something?

In my case i serialize structures in same assembly where structures and serializers are placed. I did not test [InternalsVisibleTo].

Btw, i also generate so-called activator with RegisterOverride for serializers and MsgPack.Serialization.MessagePackSerializer.PrepareType for nested types. And everything is ok for my Unity iOs builds.

@yfakariya
Copy link
Member

Hi @skondratov,

OK, I understand your intent. Thank you for contribution!

@yfakariya yfakariya merged commit 8a9411f into msgpack:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requires or request to feature enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants