-
Notifications
You must be signed in to change notification settings - Fork 321
Add GitHub Action workflow (x64) and Travis (arm64) build #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yuokada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: olafurpg/setup-scala@v7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the AdoptJDK installation is supported in setup-java action, it's better to replace with it.
https://github.com/actions/setup-java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgpack-java's test is written in Scala, and also setup-scala can install natively-built sbt (csbt) using GraalVM. So let me keep using setup-scala.
| with: | ||
| path: ~/.cache | ||
| key: ${{ runner.os }}-jdk11-${{ hashFiles('**/*.sbt') }} | ||
| restore-keys: ${{ runner.os }}-jdk11- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this key correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It has fallback mechanism https://github.com/actions/cache#inputs (fixed the link)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read below document after I wrote above comment. And though I understood the specification of restore-keys, I forgot removing it.
https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows
Uh oh!
There was an error while loading. Please reload this page.