Update msgpack.c。貌似缺少一个头文件引入的判断#43
Merged
laruence merged 1 commit intomsgpack:masterfrom Mar 24, 2015
Merged
Conversation
我们买了SAE的MAE，发现他们的PHP定制过，修改了PHP的Session模块。导致MsgPack编译会报错： msgpack-0.5.5/msgpack.c:11:79: error: ext/session/php_session.h: No such file or directory 我们查看了msgpack.c的源码，发现所有用到session的地方鸟哥都加了#if HAVE_PHP_SESSION，唯有include头文件的时候没有加。 所以我们加上了这个判断。不知理解是否正确？
laruence
added a commit
that referenced
this pull request
Mar 24, 2015
Update msgpack.c。貌似缺少一个头文件引入的判断
Member
|
it must be right. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
我们买了SAE的MAE，发现他们的PHP定制过，修改了PHP的Session模块。导致MsgPack编译会报错：
msgpack-0.5.5/msgpack.c:11:79: error: ext/session/php_session.h: No such file or directory
我们查看了msgpack.c的源码，发现所有用到session的地方鸟哥都加了#if HAVE_PHP_SESSION，唯有include头文件的时候没有加。
所以我们加上了这个判断。不知理解是否正确？