Guard Packer buffer protocol hooks with Cython critical sections#686
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix free-threading race in Packer buffer methods
Guard Jun 3, 2026
Packer buffer protocol hooks with Cython critical sections
methane
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under free-threaded Python,
memoryview(packer)can race with concurrentpack()calls becausePacker.__getbuffer__/Packer.__releasebuffer__were not using the per-object critical section used by other publicPackermethods. This change closes that gap by synchronizing both buffer-protocol hooks.Scope
msgpack/_packer.pyxin thePackerbuffer-protocol path.Change
@cython.critical_sectiondirectly above:Packer.__getbuffer__(self, Py_buffer *buffer, int flags)Packer.__releasebuffer__(self, Py_buffer *buffer)Consistency impact
Packermethod-level synchronization strategy, so exported-buffer bookkeeping (self.exports) is protected under the same lock discipline.Original prompt
This pull request was created from Copilot chat.