Fix an infinite recursion issue when registering a Symbol type with a nil packer
#332
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
previously approved these changes
Apr 18, 2023
soyed
previously approved these changes
Apr 18, 2023
Author
|
Urk, of course the Java side need fixing too. I'll deal with it tomorrow. |
… `nil` packer That would cause `has_symbol_ext_type = true` to be set, so `msgpack_packer_write_symbol_value` would invoke `Symbol#to_msgpack` which itself would call back to `write_symbol` causing infinite recursion.
casperisfine
force-pushed
the
infinite-symbol-recusrsion
branch
from
db41367 to
d7e4783
Compare
byroot
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That would cause
has_symbol_ext_type = trueto be set, somsgpack_packer_write_symbol_valuewould invokeSymbol#to_msgpackwhich itself would call back towrite_symbolcausing infinite recursion.cc @peterzhu2118 @soyed