Packer_write_extension: handle T_BIGNUM #336
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
check-ext-code-fixnum
branch
from
8293adb to
167641a
Compare
casperisfine
changed the title
The original code assumed the `ext_type` is a T_FIXNUM. But if the user submit a number large enough, it can be a T_BIGNUM which leads to an assertion error in `FIX2INT()`.
casperisfine
force-pushed
the
check-ext-code-fixnum
branch
from
167641a to
34a7400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#335 revealed this issue.
The original code assumed the
ext_typeis a T_FIXNUM.But if the user submit a number large enough, it can be a T_BIGNUM which leads to an assertion error in
FIX2INT().