JSONPrettyStorage for pretty printed storage.#60
Closed
rainwoodman wants to merge 1 commit intomsiemens:masterfrom
Closed
JSONPrettyStorage for pretty printed storage.#60rainwoodman wants to merge 1 commit intomsiemens:masterfrom
rainwoodman wants to merge 1 commit intomsiemens:masterfrom
Conversation
Closed
Owner
|
Thanks for the pull request! While the JSON storage could use more flexibility, I think the implementation can be simpler. I've implemented an alternative in #61. Could you have a look at it? |
Contributor
Author
|
Closed as dup of #61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not pretty. I wrapped JSONStorage class in a factory function for this.
Similar pattern is for the CachingStorageMiddleware The number of cached operations can't be provided as a parameter and may need to be modified as well.
I am happy to see a more elegant alternative!