Skip to content

Fix get_binary_data to use py::bytes#4

Merged
msis merged 1 commit intomsis:masterfrom
lauralindzey:get_binary_data
Jan 18, 2021
Merged

Fix get_binary_data to use py::bytes#4
msis merged 1 commit intomsis:masterfrom
lauralindzey:get_binary_data

Conversation

@lauralindzey
Copy link
Copy Markdown

Hi @msis -- this is probably only a partial fix, but I figured I'd submit a PR anyways in case it helps you work towards a more robust fix.

Caveats:

  • I haven't tested this on python2, so it may need additional work to be backwards-compatible
  • I haven't tested publishing a bytes object, since my application only requires subscribing to them.

@msis msis merged commit 1c9f83c into msis:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants