Bugfix/use facets1 gene level amp filter#772
Merged
gongyixiao merged 7 commits intodevelopfrom Apr 16, 2020
Merged
Conversation
arichards2564
approved these changes
Apr 15, 2020
anoronh4
approved these changes
Apr 15, 2020
Collaborator
anoronh4
left a comment
anoronh4
left a comment
There was a problem hiding this comment.
in line 1566 of pipeline.nf i think it might be better practice to go to back to the directory where you previously were using cd - rather than cd ../. this change is non-essential so i'm approving.
Collaborator
Author
Indeed. Fixed |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
geneLevel.R(https://github.com/mskcc/facets-suite/blob/1.6.3/geneLevel.R) from old facets-suite 1.6.3 https://github.com/mskcc/facets-suite/tree/1.6.3 to replace the*.gene_level.txtresult generated by facets-suite 2.x due to the bug mskcc/facets-suite#35This is a temporary solution until the bug is fixed in facets-suite 2.x. Please pin this issue when it's fixed in facets-suite 2.x