fix: avoid adding duplicate CSQ/ANN fields via --retain-ann#366
Merged
ckandoth merged 1 commit intomskcc:mainfrom Aug 1, 2025
dlaehnemann:patch-1
Merged
fix: avoid adding duplicate CSQ/ANN fields via --retain-ann#366ckandoth merged 1 commit intomskcc:mainfrom dlaehnemann:patch-1
--retain-ann#366ckandoth merged 1 commit intomskcc:mainfrom
dlaehnemann:patch-1
Conversation
Contributor
Author
|
I can't directly ask for a review via the interface, so I'll try by pinging in @ckandoth, who seems to have been the main maintainer. |
Collaborator
|
Thanks for the PR, and sorry for the delay. Will review and merge shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have cases where we want to ensure that certain
ANNcolumns are in the MAF file, and we generate that list programmatically in a workflow. Currently, this leads to a duplication of any field requested via--retain-ann, that is already in the default list at:vcf2maf/vcf2maf.pl
Lines 545 to 552 in 0d3f514
So this solutions filters out any
--retain-add-specified fields that are already in@ann_colsand avoids pushing them onto the column array.I just looked up all the syntax and tried it in some online perl compiler. So feel free to adjust it to whichever style you might prefer. And obviously to fix any mistakes I might have made.