Document changes in release 5.11.22

[ykazakov]

Could you, please, provide a more detailed change log for the latest version 5.11.22?

It looks like two additional dependencies cadical and cadiback are now required for the build. What are these libraries used for? Since cadical is not easy to build under windows, this means this platform has now been dropped. I find it quite a significant change for a point release.

Can you provide a bit more details about the bugs that have been fixed? If we get stuck with the previous version under windows, it would be nice to be aware about these bugs.

[msoos]

Hi,

CaDiCaL and Cadiback are needed for backbone detection. I can't remove it. Bumping a more serious version number would be appropriate. I will do that soon. I am sad it doesn't work for Windows, but I can't help it, I need backbone detection for model counting.

If you want to, you can fix cadical and cadiback, simply create a pull request for the pypi build and I'll be happy to review and merge it. Then it will work, if you fix it. Unfortunately, I don't have the capacity to do that right now. I am closing because I can't fix this issue without many days, if not week(s) of work, and that's too much. I simply don't have that time, and absolutely nobody is paying me to do this, it's 100% my free time that I should be spending with friends and loved ones.

I hope you can create a pull request to fix and then I'll be happy to review. I wish you luck and looking forward to the pull request,

Mate

[ykazakov]

Thanks for the clarification! I did not ask to remove these libraries, I was asking to clarify what were they used for, ideally in the release notes. How did backbone detection work in the previous release 5.11.21?
Does it mean that cadical and cadiback are not needed for just solving? Do you think it could be possible to disable these dependencies just to compile the IPASIR library? Thanks!

[a1880]

Using Msys64 (MingGW), the following will build CaDiCal under Windows:

#!/bin/bash
#  change ~/cppsrc to your source root directory
cd ~/cppsrc
[ -d cadical ] && rm -rf cadical
git clone https://github.com/arminbiere/cadical
cd cadical
./configure
cd build
make cadical
[ -f cadical.exe ] && cp cadical.exe /usr/local/bin/cadical.exe

[ykazakov]

@a1880 According to the cadical build instructions one should do ./configure -static -lpsapi. Otherwise the compiled binary will not work without MinGW.

I did not say that it is not possible to compile cadical for windows, I just said it is not easy to do. And this method is officially not supported.

[msoos]

I think I am making progress here. I have managed to compile the beast for Linux and Mac for pypi. Maybe Windows won't be so bad. Perhaps WSL will do the trick? I'll see... We need to fight the ./configure scripts in CaDiCaL and Cadiback, and install GMP. No other library needed, and everything else should compile without a hitch. So maybe it'll work. I'll see...

[PolarGoose]

In case you just need an executable for Windows, it is possible to use MSYS2 as I described here: #782 . It is easy to create a GitHub Actions workflow to produce the binary. But I'm not sure it will work for Python bindings.

In case you want to make it compile on Windows natively, you can get GMP library through VcPgkg, and cadical and cadiback libraries can be built through a custom cmake file, you don't have to use their autoconf build scripts. However, I'm not sure that cadical can be built on Windows natively, because some cpp files use Linux-only headers.

[msoos]

There is a static Windows binary attached to the latest release now: https://github.com/msoos/cryptominisat/releases/tag/release%2F5.13.0 Yay! I hope this helps. I am closing this ticket. In case it doesn't work, please re-open this bug report, or open a new one!

Thanks for everyone, especially @a1880 for all the help with this!

Mate