Fix Claude Code hook installer: use correct settings.json schema#29
Merged
Fix Claude Code hook installer: use correct settings.json schema#29
Conversation
Our installer wrote a flat list of {event, command} objects, but Claude
Code expects hooks as a dict keyed by event name, with each entry being
a list of matcher objects containing a nested hooks array:
{
"hooks": {
"UserPromptSubmit": [
{"hooks": [{"type": "command", "command": "..."}]}
]
}
}
Updates tests to assert the correct schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer was writing a flat list of
{event, command}objects, which is wrong. Claude Code expects:{ "hooks": { "UserPromptSubmit": [ { "hooks": [{"type": "command", "command": "..."}] } ] } }Found by actually running
pretty-please install-hook— theAttributeError: 'str' object has no attribute 'get'was caused by iterating over the dict keys instead of a list of hook objects.🤖 Generated with Claude Code