Skip to content

Conversation

@lwnmengjing
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@lwnmengjing lwnmengjing requested review from Copilot and mss-boot July 28, 2025 12:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the application configuration key format to use colon separators instead of dot separators throughout the codebase. This change affects how configuration keys are retrieved from the app config system.

  • Configuration key format changed from dot notation (e.g., "storage.type") to colon notation (e.g., "storage:type")
  • Updated all GetAppConfig() calls across multiple service files to use the new format
  • Minor import reordering in the app_config.go model file

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
service/storage.go Updated storage-related config keys to use colon separators
models/app_config.go Reordered imports (moved gorm import after standard library imports)
apis/user.go Updated email and security config keys to use colon separators
apis/github.go Updated GitHub OAuth config keys to use colon separators
Comments suppressed due to low confidence (1)

apis/github.go:68

  • The config key 'security:githubRedirectURL' uses a different casing pattern than other keys in the same file. Should be 'security:githubRedirectUrl' to match the pattern used in apis/user.go line 624.
	redirectURL, _ := center.GetAppConfig().GetAppConfig(c, "security:githubRedirectURL")

@github-actions
Copy link

Field Coverage
total: 3.8%

@github-actions
Copy link

Field Coverage
total: 3.8%

@lwnmengjing lwnmengjing merged commit 457380c into main Jul 28, 2025
1 check passed
@lwnmengjing lwnmengjing deleted the fix/app-config branch July 28, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants