Make PyPI publish step idempotent (skip-existing: true)#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
skip-existing: truetopypa/gh-action-pypi-publishinrelease.yml. The action now returns success when a file already exists on PyPI instead of erroring with HTTP 400.Why
v1.0.1's first successful publish run uploaded all six artifacts. A subsequent re-run (or a partially-completed run that the user retries) tries to re-upload the same files, and PyPI rejects file reuse with
400 Bad Request. Withoutskip-existing, that second run is marked failed even though the release is fully shipped — noisy and confusing.With
skip-existing, future re-runs are no-ops if the version is already published, and partial uploads can be safely retried.Test plan