Implement Import Wizard to easily migrate Docker Containers to Compose#92
Open
Implement Import Wizard to easily migrate Docker Containers to Compose#92
Conversation
…review generation
…details and previews to match new base
…compose functions
- Implemented CSS styles for the Import Wizard, including a 6-stage stepper, service configuration cards, healthcheck sections, and validation stages. - Created unit tests for new backend functions related to the Import Wizard, covering duration conversion, port mapping parsing, healthcheck guessing, port conflict detection, and YAML generation for Docker services.
…anager containers to Compose stacks
…d adjust stage flow
…heming and consistency
…and improve stage navigation
The .editor-validation.error rule was removed and several CSS rules (.settings-panel, .settings-section, .settings-section-title, .settings-field) had invalid nesting with unrelated rules embedded inside. Restores the .editor-validation.error rule and fixes all broken CSS by removing invalid nesting and restoring proper top-level rules. Co-authored-by: copilot-pull-request-reviewer[bot]
The UI implements a 5-stage flow (generating + validation merged into "Review & Import"), but docs and backend comments still referenced a 6-stage workflow. Update all references to 5-stage and merge the docs for stages 5/6 into a single "Review & Import" stage. Co-authored-by: copilot-pull-request-reviewer[bot]
yamlQuoteValue() was casting all values to string before checking
is_numeric(), which caused integer fields like healthcheck.retries
to be emitted as quoted strings ("3") instead of bare numbers (3).
Docker Compose schema validation expects integers for these fields.
Now checks is_int/is_float first and returns them as bare YAML
scalars. Numeric strings (passed as string type) are still quoted
to prevent YAML misinterpretation.
Co-authored-by: copilot-pull-request-reviewer[bot]
The review screen allowed clicking Import even when validation.valid was false. Since this flow can stop/remove original containers, proceeding with invalid compose is risky. Adds actionDisabled support to wizardFooter and disables the Import button when the generated compose YAML fails validation. Co-authored-by: copilot-pull-request-reviewer[bot]
performImportTransfer wrote compose/.env/override files via file_put_contents() without checking for write failures, then proceeded to stop/remove source containers regardless. This could cause data loss if files were not written (permissions, full disk). Now checks return values and aborts with an error before touching any containers if any file write fails. Co-authored-by: copilot-pull-request-reviewer[bot]
The WebUI link in the import wizard container table used target="_blank" without rel="noopener noreferrer", allowing the opened page to access window.opener (tabnabbing risk). Co-authored-by: copilot-pull-request-reviewer[bot]
…r per-service unions
…in ExecActionsTest
…removing containers
When both stopContainers and removeContainers are enabled, docker rm -f already force-stops the container. Running docker stop first is redundant and doubles shutdown time per container.
Superseded by generateImportData which returns richer per-service metadata for the 5-stage wizard. No frontend callers exist for this action.
Frontend stores __originalTestType and __originalTestCmd as metadata inside healthcheck objects for CMD/CMD-SHELL type preservation. These private keys leaked through to the YAML emitter because they weren't filtered. 1. Backend: skip __-prefixed keys when emitting healthcheck YAML 2. Frontend: strip __original* keys before sending to finalizeImportCompose
…s function for container deduplication
…s for improved error handling and metadata generation
…esses in Docker services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a major new feature: an Import Wizard for converting existing Docker Manager containers into Compose stacks, along with backend API endpoints and a new documentation page. It also includes several UI and style improvements to the editor modal. The most important changes are grouped below.
New Feature: Import Wizard
source/compose.manager/include/Exec.php,README.md,docs/import-wizard.md) (Ff4ba988R77, [1] [2]docs/import-wizard.md,README.md) [1] [2]Backend API Endpoints
Exec.phpto support the Import Wizard, including: container discovery (getDockerContainersForImport), import preview generation, rich import data for the wizard, Compose YAML validation, and performing the import transfer (with options to stop/remove source containers and start the new stack). (source/compose.manager/include/Exec.php) (Ff4ba988R77)UI/UX Improvements
source/compose.manager/sheets/EditorModal.css) [1] [2] [3] [4]These changes collectively introduce a powerful workflow for migrating existing Docker containers into managed Compose stacks, with a focus on user guidance, validation, and safety.