Various issues / improvements

[Squidly271]

https://github.com/mstrhakr/plugin-docs/blame/e93ab06a83039fae643936cb3587a0f9a61ff366/docs/core/plugin-settings-storage.md#L100

All the details about defaults is redundant. Saving the default config in the .plg file means that if a new entry is added, or a default changes then the update won't get the new entry because the .cfg file already exists

Handle defaults by having /usr/local/emhttp/plugins/myPlugin/default.cfg

Calling parse_plugin_cfg will automatically handle the merging, so there's never a need to reapply the defaults every single time any script executes. They just call parse_plugin_cfg. And additional entries are handled just by adjusting default.cfg

[Squidly271]

cron settings.

Easiest to simply have /boot/config/plugins/myplugin/myplugin.cron

That file is the cron entry and will automatically get added to the system during install. If manually changing the file, then update_cron script can be called.

[Squidly271]

JS for checking and displaying update available etc.

Just use https://github.com/unraid/webgui/blob/e9b1f01ea0bd2f2fd9ed36fe7b069c68c5917cc6/emhttp/plugins/dynamix.plugin.manager/PluginHelpers.page#L50

Much easier and built-in and available on every page

[Squidly271]

plugin file reference.

Any non-zero exit code from any of the sections aborts installation completely. If non zero is possible normally, ensure that the inline code always returns 0

Each section also support min / max attributes to conditionally execute / download based upon OS version

[Squidly271]

.xml for CA

Won't work as its shown. ..... needs to either be .... or ...

[Squidly271]

$theme = $Dynamix['theme'];

$theme is already exported. Generally every entry in $Dynamix is already exported. Don't change any of the variables

IE: $theme is already === $Dynamix['theme']. Don't modify or change any of the vars since they can be referenced elsewhere in .page files

[mstrhakr]

Thank you for the assist! I will implement these fixes right away and check my other projects for these issues as well.