fix(xtask): narrow scancode partial-success reuse#594
Merged
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare-outputsso ScanCode is only reused after a non-zero exit when it still produced valid JSON that clearly encodes file-level non-fatal scan errorsnpm/clibenchmark entry as an end-state comparison, including the verified 4-process compare context and the concrete Provenant advantages over ScanCodeScope and exclusions
xtask/src/bin/compare_outputs.rspartial-success validation tighteningdocs/BENCHMARKS.mdand scorecard wording cleanup for the verifiednpm/cliresultnpm/cliverification artifactsIntentional differences from Python
scan_errors.Follow-up work
yarnpkg/berry,oven-sh/bun,vercel/next.js, andmicrosoft/vscoderemain future work under the now-verified rowExpected-output fixture changes
testdata/npm/package-lock-v1-unnamed-root.json,testdata/npm/package-lock-v1-unnamed-root.json.expected.jsonname/version/purlfieldsVerification
cargo test npm_lockcargo test --release --features golden-tests test_golden_npm_lock_v1_unnamed_rootcargo test --manifest-path xtask/Cargo.toml --bin compare-outputs validate_scancode_output_on_failurenpm run check:docsCompare-run notes
.provenant/compare-runs/20260409T124932Z-cli-3457.provenant/compare-runs/20260409T113235Z-cli-99118/raw/scancode.json