Skip to content

fix(output): keep schema-backed party nulls on the wire#667

Merged
mstykow merged 1 commit intomainfrom
fix/party-null-schema
Apr 14, 2026
Merged

fix(output): keep schema-backed party nulls on the wire#667
mstykow merged 1 commit intomainfrom
fix/party-null-schema

Conversation

@mstykow
Copy link
Copy Markdown
Owner

@mstykow mstykow commented Apr 14, 2026

Summary

  • keep schema-backed party keys (type, role, name, email, url) present as explicit null when absent so Provenant matches ScanCode's documented Party shape and current package outputs more closely
  • extend the JSON writer contract test to cover both top-level packages[] and nested files[].package_data[] party serialization

Issues

  • Covers: follow-up schema-shape audit for ScanCode-backed fields
  • Closes:

Scope and exclusions

  • Included:
    • OutputParty serialization shape for ScanCode-backed fields
    • focused public JSON contract assertions for package and package_data party objects
  • Explicit exclusions:
    • no broader package/dependency null-vs-omitted overhaul
    • no changes to runtime-only license-match fields in this PR

Intentional differences from Python

  • None.

Follow-up work

  • Created or intentionally deferred:
    • continue the broader schema/runtime audit for remaining non-party fields where ScanCode docs are stale or incomplete

Expected-output fixture changes

  • Files changed: none
  • Why the new expected output is correct:
    • the change is covered by a focused writer contract test rather than golden fixture refreshes, and it aligns the emitted party shape with both the formal ScanCode Party schema and upstream package outputs that use explicit null for absent party fields

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@mstykow mstykow force-pushed the fix/party-null-schema branch from 7b8d31c to ab2b7a1 Compare April 14, 2026 19:36
@mstykow mstykow merged commit f97c54e into main Apr 14, 2026
14 checks passed
@mstykow mstykow deleted the fix/party-null-schema branch April 14, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant