fix(output): preserve hoisted SPDX license data#701
Merged
Conversation
Serialize file-level detected SPDX expressions from SPDX-bearing detections instead of the overloaded internal field so hoisted output stays aligned with nested license detections. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Carry declared and other license expressions, SPDX siblings, and detections from parsed copyright metadata into merged Debian package data so package hoists do not silently drop computed license output. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Include other SPDX sibling fields in package and reference-follow golden projections so future hoisting regressions are visible in fixture comparisons. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Update post-processing reference-follow expected output to match the corrected file-level SPDX hoist for MIT-based fixtures. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Update the file-to-package inheritance golden to expect the corrected BSD SPDX hoist at the file level. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Align the package tallies golden with the repo's current public-domain SPDX mapping now that the package projection compares that field explicitly. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detected_license_expression_spdxfrom SPDX-bearing detections instead of the overloaded internal file fieldother_license_expression_spdxin golden package/reference-follow projections so sibling hoist regressions stay visibleScope and exclusions
Intentional differences from Python
Follow-up work