fix(progress): remove duplicate 'Post-processing scan results...' log#705
Merged
fix(progress): remove duplicate 'Post-processing scan results...' log#705
Conversation
start_post_scan() was called three times in main.rs, causing the phase announcement to print multiple times in verbose mode. The second and third calls wrapped post-assembly steps that were mislabeled as post-scan steps when they logically belong to the assembly phase. - Add assembly_step() to ScanProgress (mirrors post_scan_step/finalize_step) - Move path normalization, package license provenance backfill, and package reference following into the assembly phase - Move finish_assembly() to after all assembly steps - start_post_scan() now called exactly once, so the announcement prints once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_post_scan()was called 3 times inmain.rs, causing "Post-processing scan results..." to print multiple times in verbose mode--no-assembleis set — no spurious log messages or no-op workHow I tested
cargo check/ clippy / rustfmt passtestdata/about/: "Post-processing scan results..." appears exactly once--no-assemble: assembly section is completely absent from output