fix(license): preserve nested detection expressions for Deno verification#757
Merged
fix(license): preserve nested detection expressions for Deno verification#757
Conversation
Keep aggregated SPDX and ScanCode expressions from absorbing distinct nested operands so compare-output and file-level detections retain the full match-derived structure. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Avoid overwriting detection-level SPDX expressions after match aggregation so scanner and compare-output results keep the full structure that the matched rules produced. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Keep file-level detected license expressions aligned with the aggregated detection structure so JSON output reflects the same match-derived SPDX shape used during comparison. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Add the verified fresh, oak, and std Deno snapshots to the benchmark reference and regenerate the chart so the checked-in timing stats reflect the new rows. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Record the completed Deno compare-output lane in the parser verification scorecard now that fresh, oak, and std are all triaged and benchmarked. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MIT AND (Apache-2.0 OR MIT)toMITcompare-outputs --profile commonfordenoland/fresh,oakserver/oak, anddenoland/std, then record the verified Deno snapshots indocs/BENCHMARKS.mddocs/benchmarks/scan-duration-vs-files.svgIssues
docs/implementation-plans/package-detection/PARSER_VERIFICATION_SCORECARD.mdScope and exclusions
.provenant/compare-runs/20260422T104059Z-fresh-39844.provenant/compare-runs/20260422T104059Z-oak-39847.provenant/compare-runs/20260422T103358Z-std-31214denoland/stdIntentional differences from Python
Follow-up work
update-license-golden -- --list-mismatches --show-diffprechecks formisc.candcomplex3.javareportedwould update 0 file(s)Expected-output fixture changes