fix(parser): preserve opam metadata after inline descriptions#758
Merged
fix(parser): preserve opam metadata after inline descriptions#758
Conversation
Preserve later opam fields when descriptions are inline or move to the next quoted line, while keeping existing triple-quoted fixture behavior stable across the parser and golden tests. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Record the dune, ocaml-lsp, and merlin compare-output results, regenerate the benchmark chart summary, and mark the OCaml/opam scorecard row verified. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
description:is inline or moves to the next quoted line, while keeping existing triple-quoted fixture behavior stable.compare-outputs --profile commononocaml/dune,ocaml/ocaml-lsp, andocaml/merlin, then record the benchmark rows and mark the scorecard row verified..provenant/compare-runs/20260422T115905Z-dune-32635/,.provenant/compare-runs/20260422T120550Z-ocaml-lsp-41966/,.provenant/compare-runs/20260422T120950Z-merlin-47624/.Issues
OCaml / opam)Scope and exclusions
Intentional differences from Python
.for-opamDune workspace files as non-opam inputs even when ScanCode heuristically reportsopampackage data on them, because the file contents are Dune syntax rather than opam manifest syntax.Follow-up work
Expected-output fixture changes