Merged
Conversation
Demote the bare GPL1 shorthand rule to clue-only evidence so versionless GPL1 tokens remain inspectable without surfacing as hard GPL detections. The change is intentionally isolated to gpl1_bare_word_only.RULE, mirroring the existing bare-GPL treatment without widening policy to neighboring GPL phrase rules. This follows upstream ScanCode false-positive history around bare GPL1 tokens in code and labels: aboutcode-org/scancode-toolkit#2585, kernel-symbol false positives in #1914 fixed by #1963, and later GPL1/GPL2/GPL3 label noise in #3932 fixed by #4106. Those threads consistently point to GPL1 as weak shorthand that is too fragile for asserted license output. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpl1_bare_word_only.RULEto clue-only evidence so bareGPL1tokens remain visible without surfacing as hardGPL-1.0detectionsGPL1bare-word rule family only; no adjacent GPL phrase rules are adjusted hereGPL1is surfaced as a clue rather than a detected license expressionIssues
GPL1tokens in gpl1+ gpl2+ false detection aboutcode-org/scancode-toolkit#2585, kernel-symbol false positives in #1914 fixed by #1963, and laterGPL1/GPL2/GPL3label noise in #3932 fixed by #4106Scope and exclusions
gpl1_bare_word_only.RULEGPL1clue outputgpl_194.RULEorgpl-1.0-plus_200.RULEIntentional differences from Python
GPL1the same way Provenant already treats bareGPL: as weak shorthand that should remain inspectable as a clue, but not be asserted as a hard license detection. That is narrower than a general GPL phrase policy and is specifically motivated by the upstream false-positive history in #2585, #1914/#1963, and #3932/#4106.Follow-up work
released under the GPL(gpl_194.RULE) andunder the GPL(gpl-1.0-plus_200.RULE) until there is similarly direct upstream false-positive evidence for those exact rulesExpected-output fixture changes
resources/license_detection/overlay/rules/gpl1_bare_word_only.RULE,resources/license_detection/license_index.zstGPL1is weak shorthand analogous to the already-demoted bareGPLfamily, and current upstream issue history shows repeated false positives from code tokens and labels rather than reliable substantive license notices