fix(copyright): restore detector authors and cover tests in CI#780
Merged
fix(copyright): restore detector authors and cover tests in CI#780
Conversation
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refine_final_authorsso it no longer drops valid authors that earlier detector heuristics already accepted, including maintainer lines with trailing handles and structured metadata names likegRPC authors,Meta,The libunwind project, andS2Geometrycopyright::detectorunit-test target to greenRust Library Testswas only runningcargo test --bin provenant, so detector library tests were never exercised; this PR renames that job/step accurately and adds a dedicatedcargo test -p provenant-cli --lib --release copyright::detector::stepIssues
Scope and exclusions
copyright::detector, and clearer unit-test job namingcargo test -p provenant-cli --lib --releasetarget. Local validation surfaced unrelated pre-existing non-detector lib-target failures, so this PR fixes the missed copyright coverage without expanding into those separate failures.Intentional differences from Python
Follow-up work
--libtests separately, then consider broadening CI to full library-target coverage once that suite is greenExpected-output fixture changes