fix: restore hidden library regressions and CI coverage#782
Merged
Conversation
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Signed-off-by: Adrian Braemer <bradrian@gmail.com>
70cadb1 to
2d648d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-library-teststo real library coverage by runningcargo test -p provenant-cli --lib --release --verbose -- --skip _scan_test::again. The earlier CI change swapped that job tocargo test --bin provenant --release --verbose -- --skip _scan_test::, which runs0 testsin this repository and silently stopped covering the library suite.refine_final_authors()was over-pruning valid author detections afterfix(copyright): drop prose and trademark boilerplate noise, so handle-suffixed maintainer authors and structured metadata authors likegRPC authors,Meta,The libunwind project, andS2Geometrywere being dropped. The fix reuses the existing detector heuristics that had already accepted those forms.4376 passed; 0 failed; 66 filtered out.Issues
copyright::detectorfailures that were not exercised by CI, and the follow-on library regressions exposed when therust-library-testsjob was restored.Scope and exclusions
rust-library-testsonce again runs the actual library suite, while leaving_scan_test::parser scanner/assembly contract tests in the separatecontractsshard.assembly::file_ref_resolveduplicate resolver registration introduced by BitBake append support by merging theRelativeToDatafileParentdatasource IDs into a single config entry..local,.blank,.fill, and related suffix filtering alongside the newer file-like host suffixes.fix(replay): retain imported directories during filtering.fix(cli): keep bare include paths non-recursive.resolve_native_scan_inputs_*flaky.fix(license): keep match-derived SPDX detection output.recipe.yamlsupport._scan_test::contract tests were moved back into the main library job; they remain intentionally split into thecontractsshard for CI sharding.Follow-up work
rust-library-tests,_scan_test::contract coverage in thecontractsshard, and integration/golden coverage in their existing jobs.