Skip to content

fix(scanner): normalize redundant SPDX match parentheses#784

Merged
mstykow merged 1 commit intomainfrom
fix/match-spdx-normalization
Apr 24, 2026
Merged

fix(scanner): normalize redundant SPDX match parentheses#784
mstykow merged 1 commit intomainfrom
fix/match-spdx-normalization

Conversation

@mstykow
Copy link
Copy Markdown
Owner

@mstykow mstykow commented Apr 24, 2026

Summary

  • normalize public license_expression_spdx rendering for detections and nested matches so redundant top-level parentheses are removed consistently
  • add a regression test covering (MIT OR CC0-1.0) at both detection and match level
  • keep the fix scoped to the scanner conversion boundary, reusing the existing SPDX combiner instead of changing internal detection behavior

Scope and exclusions

  • Included: src/scanner/process/license.rs and src/scanner/process/license_test.rs
  • Explicit exclusions: no changes to internal license detection generation, no golden fixture updates, and no broader output-schema refactors

Normalize public detection and match SPDX expressions so redundant top-level parentheses are removed consistently across license output fields.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
@mstykow mstykow enabled auto-merge (rebase) April 24, 2026 11:04
@mstykow mstykow merged commit 5ab529b into main Apr 24, 2026
15 checks passed
@mstykow mstykow deleted the fix/match-spdx-normalization branch April 24, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant