fix(copyright): recover eigen benchmark author parity#816
Merged
Conversation
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
84dd53a to
c743074
Compare
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copyright (c) ... by ...lines on the shared holder-extraction path, stop treatingXerox Corporationas junk holder text, and tighten follow-up holder recovery so prose-onlycopyright notice of ...spans do not leak holders while real names like42North Inc.are preservedcompare-outputsforValveSoftware/eigen @ e9c43151265207fd3366bba21cddd61141ff402cwith the maintainedcommonprofile and the same shared ScanCode cache identityeigen-43257), which keeps0package deltas,0dependency deltas, and42vs42top-level license detections, then sync the small set of copyright-golden expectations whose cleaner holder/copyright output is now intentionally preservedIssues
ValveSoftware/eigenScope and exclusions
src/copyright/detector/pattern_extract/extraction/groups.rssrc/copyright/detector/postprocess_transforms/year_repairs.rssrc/copyright/detector/postprocess_transforms_test.rssrc/copyright/detector/tests_copyright_holder_pipeline.rssrc/copyright/detector/tests_false_positives.rssrc/copyright/detector/token_utils/filters.rssrc/copyright/refiner/holders_junk_patterns.rssrc/copyright/refiner/tests.rsdocs/BENCHMARKS.mddocs/benchmarks/scan-duration-vs-files.svgtestdata/copyright-golden/copyrights/Distributedholder overcapture inbench/eig33.cppIntentional differences from Python
bench/eig33.cppholder delta is a weak license-prose overcapture (Distributed) that Provenant intentionally does not model as a holder.Follow-up work
Expected-output fixture changes
testdata/copyright-golden/copyrights/misco2/regexhq/regexhq-115.txt.ymltestdata/copyright-golden/copyrights/misco2/regexhq/regexhq-204.txt.ymltestdata/copyright-golden/copyrights/libopenthreads12-libopenthreads.copyright.ymltestdata/copyright-golden/copyrights/wxWindows_Library_.0_variant.yml(or...suffixescopyright notice of ...text from leaking holders and preserve real derived names like42North Inc.cargo test test_refine_holder_keeps_xerox_corporationcargo test test_derive_holder_from_simple_copyright_string_strips_by_prefixcargo test test_derive_holder_from_simple_copyright_string_keeps_leading_digitscargo test test_comment_led_by_keyword_holder_backfilledcargo test test_copyright_notice_of_prose_does_not_emit_xerox_holdercargo test --features golden-tests --test copyright_golden test_fixture_misco3_not_real_copyrights -- --nocapturecargo test --features golden-tests --test copyright_golden test_golden_copyrights -- --nocapturecargo test --features golden-tests --test copyright_golden test_golden_holders -- --nocapturecargo run --manifest-path xtask/Cargo.toml --bin compare-outputs -- --repo-url https://github.com/ValveSoftware/eigen.git --repo-ref e9c43151265207fd3366bba21cddd61141ff402c --profile common