fix(nuget): narrow legacy project.json recognition for GitLab verification#830
Merged
fix(nuget): narrow legacy project.json recognition for GitLab verification#830
Conversation
Avoid false positive NuGet package extraction from generic GitLab export fixtures while preserving fallback rows for malformed legacy manifests. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Align the supported-formats and improvement docs with the narrowed legacy project.json parser so the user-facing NuGet surface matches the actual recognition rules. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Record the reviewed compare-outputs result for gitlabhq/gitlabhq and refresh the benchmark chart summary with the new same-host timing data. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Drop generic field-label, translation-placeholder, enum-blob, and (c)-prefixed code-expression noise in the refiner while preserving validated maintainer, structured-credits, obfuscated-contact, and real holder/copyright detections. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Tighten code-call and generic-label filtering so valid collective holders, lowercase company suffixes, and parenthetical variants survive the new noise cleanup without reopening the repo-specific junk buckets that motivated the refiner pass. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Preserve lowercase company suffix holders from parsed token spans and recover lowercase hyphenated names from copyright-plus-URL forms so real project and company identities survive detector cleanup without broad holder backfill regressions. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Add regression coverage for collective holders, lowercase company suffixes, lowercase handle emails, lowercase hyphenated project names, and detector token-span holder recovery so the branch-local CI breakage stays fixed under future detector and refiner changes. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Update the owned copyright golden expectations to reflect the new detector/refiner end state: junk code fragments stay holder-free, malformed (c) fixtures drop out, and Project Mayo keeps the improved holder while preserving the shorter copyright variant that still survives extraction. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitlabhq/gitlabhqwith the maintainedcompare-outputsworkflow in the context of PR 826's Ruby changes, and record the reviewed benchmark snapshot indocs/BENCHMARKS.mdproject.jsonfixtures as legacy NuGet manifests by requiring legacy NuGet shape keys before parser extraction or fallback rowsproject.jsonbehaviorIssues
Scope and exclusions
src/parsers/nuget/project_json.rssrc/parsers/nuget/nuget_test.rsdocs/BENCHMARKS.mdanddocs/benchmarks/scan-duration-vs-files.svgdocs/improvements/nuget-parser.mdand generateddocs/SUPPORTED_FORMATS.mdproject.jsonrecognitiongitlabhq/gitlabhqcompare snapshotIntentional differences from Python
project.jsonsupport now requires legacy-manifest shape rather than filename alone, which keeps generic GitLab export fixtures out of NuGet output while preserving fallback rows for malformed but still probable legacy NuGet manifests::VERSIONplaceholdersFollow-up work
.provenant/compare-runs/20260430T174411Z-gitlabhq-45077.provenant/compare-runs/20260430T194138Z-gitlabhq-85785cargo test test_project_json_cargo test --features golden-tests test_golden_project_jsoncargo run --manifest-path xtask/Cargo.toml --bin generate-benchmark-chartcargo run --manifest-path xtask/Cargo.toml --bin generate-supported-formats