fix(verification): close react-i18next compare gaps#831
Merged
Conversation
Preserve lowercase project names that trail year ranges such as Copyright (c) 2015-present i18next while classifying bundled HTML-entity decoder artifacts as code noise so the react-i18next verification no longer loses real holders or invents regex junk notices. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Descend into if/else blocks inside dependencies closures so static React Native Gradle manifests keep conditional dependencies مثل hermes-android visible instead of dropping them as nested closures. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Record the pinned react-i18next compare run as a new Apple/mobile benchmark example after the remaining meaningful parser gap was closed and the residual deltas were triaged as normalization or test-noise differences. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copyright (c) 2015-present i18nextwhile filtering bundled HTML-entity decoder regex junk out of copyright and holder detectionif/elseblocks inside Gradle dependency closures so React Native example apps keep static dependencies such ascom.facebook.react:hermes-androidi18next/react-i18next @ cb20d18compare snapshot indocs/BENCHMARKS.mdand regenerate the benchmark chartIssues
i18next/react-i18nextScope and exclusions
src/copyright/**for lowercase project tails and HTML-entity decoder artifact suppressionsrc/parsers/gradle.rsfor conditional dependency extraction insidedependencies { ... }docs/BENCHMARKS.mdanddocs/benchmarks/scan-duration-vs-files.svgIntentional differences from Python
${FLIPPER_VERSION}placeholders.Jan Mühlemann) and HTML-entity decoder test-noise patterns rather than meaningful parser blind spots.Follow-up work
.provenant/compare-runs/20260501T072233Z-react-i18next-43501.provenant/compare-runs/20260501T082746Z-react-i18next-18917cargo test test_lowercase_project_name_after_present_year_range_is_keptcargo test test_is_junk_copyright_drops_html_entity_regex_fragmentscargo test test_conditional_dependencies_inside_if_blocks_are_extractedcargo test test_gradle_scan_resolves_buildsrc_kotlin_constantscargo test tests::test_golden_copyrights --test copyright_golden --features golden-testscargo test tests::test_golden_summary_fixtures_match_expected_summary_blocks --test post_processing_golden --features golden-testscargo test test_scanner_detects_copyrights_in_windows_dll_strings --test scanner_integrationcargo test copyright::detector::tests_structured_metadata::cargo test copyright::refiner::tests::