fix(copyright): improve zlib verification attribution#832
Merged
Conversation
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
written on top of ... byprose, plus trim prose tails after contact-bearing attributionsmadler/zlibwithcompare-outputs --profile common, rerun narrow copyright golden coverage, and record the benchmark snapshot indocs/BENCHMARKS.mddocs/benchmarks/scan-duration-vs-files.svgafter adding the zlib rowIssues
madler/zlibverification work fromdocs/implementation-plans/package-detection/PARSER_VERIFICATION_SCORECARD.mdScope and exclusions
Intentional differences from Python
LicenseRef-scancode-info-zip-2009-01 AND Zlibclassification oncontrib/minizip/unzip.cinstead of collapsing it to plainZlibFollow-up work
Expected-output fixture changes
test_golden_authorsandtest_golden_ics, so no owned fixture drift required an updateVerification
cargo test plaintext_roster_lines_extract_individual_authors --libcargo test written_on_top_of_line_extracts_author --libcargo test refine_author_truncates_trailing_prose_after_contact --libcargo test written_by_author_email_for_project_is_extracted --libcargo test --features golden-tests test_golden_authors --test copyright_goldencargo test --features golden-tests test_golden_ics --test copyright_goldencargo run --manifest-path xtask/Cargo.toml --bin compare-outputs -- --repo-url https://github.com/madler/zlib.git --repo-ref f9dd6009be3ed32415edf1e89d1bc38380ecb95d --profile commoncargo run --manifest-path xtask/Cargo.toml --bin generate-benchmark-chartCompare artifacts
.provenant/compare-runs/20260501T105917Z-zlib-47314/.provenant/compare-runs/20260501T104122Z-zlib-6507/