Skip to content

fix(parsers): gate rpm db impls by sqlite feature#884

Merged
mstykow merged 1 commit into
mainfrom
fix/rpm-db-cfg-conflict
May 21, 2026
Merged

fix(parsers): gate rpm db impls by sqlite feature#884
mstykow merged 1 commit into
mainfrom
fix/rpm-db-cfg-conflict

Conversation

@mstykow
Copy link
Copy Markdown
Owner

@mstykow mstykow commented May 21, 2026

Summary

  • make the RpmBdbDatabaseParser trait impls mutually exclusive across rpm-sqlite feature states
  • restore the required PackageParser members on the non-rpm-sqlite impl to fix the --no-default-features build
  • gate the SQLite-only path suffix constant so the non-SQLite build stays clean

Issues

  • Covers: RPM DB parser feature-gating regression in src/parsers/rpm_db.rs

Scope and exclusions

  • Included: one-file parser fix for cfg-gated trait impl completeness and SQLite-only constant gating
  • Explicit exclusions: no parser behavior changes outside the cfg split, no assembly wiring changes, no documentation or fixture updates

Follow-up work

  • Created or intentionally deferred: no blocking follow-up; five-agent review and focused local QA passed for default-feature and --no-default-features paths

Expected-output fixture changes

  • Files changed: none
  • Why the new expected output is correct: this fix only resolves a cfg-gated compile/trait-completeness issue and does not intentionally change parser output

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
@mstykow mstykow merged commit 0519038 into main May 21, 2026
15 checks passed
@mstykow mstykow deleted the fix/rpm-db-cfg-conflict branch May 21, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant