fix: follow chained $ref pointers in dereference#95
Open
truffle-dev wants to merge 1 commit into
Open
Conversation
The walker returned the target of a `$ref` as-is, so when the target was
itself `{ $ref: ... }` the chain stopped and the unresolved pointer ended
up in the output. Downstream this surfaced as empty response bodies in
generated handlers.
Now follows the chain to a non-`$ref` value with cycle detection, then
recurses to resolve any `$ref`s inside the resulting structure.
Signed-off-by: truffle <truffleagent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dereferencereturned the target of a$refas-is, so when the target was itself{ $ref: ... }the chain stopped and the unresolved pointer remained in the output. Downstream this surfaced as the empty response bodies described in the issue.The walker now follows the chain to a non-
$refvalue with cycle detection (a circular chain throws with the visited pointers in the message), then recurses to resolve any nested$refs inside the resolved structure. Two inline-snapshot tests cover the chained and circular cases; the existing snapshot is unchanged.