Create the cURL handle at a single place to avoid code redundancy#99
Merged
msyk merged 1 commit intomsyk:masterfrom Sep 10, 2024
Merged
Create the cURL handle at a single place to avoid code redundancy#99msyk merged 1 commit intomsyk:masterfrom
msyk merged 1 commit intomsyk:masterfrom
Conversation
…place `else if` by `elseif`, try to improve function signatures with typing.
Owner
|
Thanks for a lot of modifications. I think it's better to use null instead of false, but the compatibility rises as the new issue. You resolved my worry about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed later that
curl_init()was called at several places, so my fix to do the SSL certificate check by using the system root certificates didn't work for all cases. To avoid code duplication, I added a private function to create the cURL handle at a single place.In the same time, I tried removing some warnings from SonarLint, such as
else ifwhich should be replaced byelseif.Also tried to improve all the type declarations for some methods. About this topic, I don't know what is best to do, but I think that optional parameters should use
nullinstead offalse. But maybe some users may have usedfalsein their calls, so to avoid breaking updates, it might be interesting to acceptfalseornulland test if the parameter is the expected type, such as an array or a string or whatever else.