Skip to content

Conversation

@S-S-X
Copy link
Member

@S-S-X S-S-X commented Feb 22, 2025

Badges for mtt, luacheck and mineunit in README.md are showing status from latest run without taking branch into account.

Statuses should only come from main release branch which is master (or default where it can be used).

Also linked badges in a way that makes it easy to find actual latest report for the master branch.

Report for most current workflow execution, where badge actually comes from, will be the very first entry instead of being hidden somewhere below development/bugfix/pending pull requests/etc.

@S-S-X S-S-X added the Bug Something isn't working label Feb 22, 2025
@S-S-X
Copy link
Member Author

S-S-X commented Feb 25, 2025

Going to add a little update for this, just yesterday noticed that I forgot chests and CNC.
Just have to add same thing for those badges too so that it grabs badges for latest master instead of latest push from any branch.

@S-S-X
Copy link
Member Author

S-S-X commented Feb 25, 2025

Added mtt badges there too while at it, @BuckarooBanzay last commit can be dropped if you think these should not be there.

@github-actions
Copy link

Mineunit failed regression tests, click for details

Regression test log for Technic CNC:


Regression test log for Technic Chests:


Regression test log for Technic:

++ Executing suite spec/api_spec.lua◼◌◌⭆ Starting test set api_spec.lua:209 ⯈ Technic API Machine use
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded
◌
++ Executing suite spec/building_spec.lua
++ Executing suite spec/chatcommands_spec.lua⭆ Starting test set chatcommands_spec.lua:7 ⯈ Chat command
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded
🢆 Running tests from  call):-1 ▷ Chat command denies /powerctrl off
Sam	You don't have permission to run this command (missing privileges: basic_privs)
🢆 Running tests from  call):-1 ▷ Chat command denies /powerctrl on
Sam	You don't have permission to run this command (missing privileges: basic_privs)
🢆 Running tests from  call):-1 ▷ Chat command denies /technic_get_active_networks
Sam	You don't have permission to run this command (missing privileges: basic_privs)
🢆 Running tests from  call):-1 ▷ Chat command denies /technic_flush_switch_cache
Sam	You don't have permission to run this command (missing privileges: basic_privs)
🢆 Running tests from  call):-1 ▷ Chat command denies /technic_clear_network_data
Sam	You don't have permission to run this command (missing privileges: basic_privs)
🢆 Running tests from  call):-1 ▷ Chat command allows /powerctrl
SX	Technic network globalstep enabled.
🢆 Running tests from  call):-1 ▷ Chat command allows /powerctrl off
SX	Technic network globalstep disabled.
🢆 Running tests from  call):-1 ▷ Chat command allows /powerctrl on
SX	Technic network globalstep enabled.
🢆 Running tests from  call):-1 ▷ Chat command allows /technic_get_active_networks
SX	Cached networks: 1 active, 1 total, 3 nodes, 0.00 max lag.
Pos:               1,50,2 PR:   1 RE:   0 BA:   0 Skip:  0 Lag:  0.30ms
🢆 Running tests from  call):-1 ▷ Chat command allows /technic_flush_switch_cache
SX	Network data removed: 1 active networks deactivated.
🢆 Running tests from  call):-1 ▷ Chat command allows /technic_clear_network_data
SX	Network data removed: 1 active networks, 1 total networks, 3 network nodes.

++ Executing suite spec/hv_network_spec.lua⭆ Starting test set hv_network_spec.lua:11 ⯈ HV machine network
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded

++ Executing suite spec/lv_network_spec.lua⭆ Starting test set lv_network_spec.lua:11 ⯈ LV machine network
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded

++ Executing suite spec/network_spec.lua
++ Executing suite spec/nodes_spec.lua⭆ Starting test set nodes_spec.lua:11 ⯈ Technic node placement
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded

++ Executing suite spec/nuclear_reactor_spec.lua⭆ Starting test set nuclear_reactor_spec.lua:7 ⯈ Nuclear reactor
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded
🢆 Running tests from nuclear_reactor_spec.lua:67 ▷ Nuclear reactor generates energy
SX	�(T@technic)Start successful�E

++ Executing suite spec/other_spec.lua⭆ Starting test set other_spec.lua:11 ⯈ Coal alloy furnace
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded
🢆 Running tests from other_spec.lua:45 ▷ Coal alloy furnace wont crash without placement callbacks
W:	InvRef:get_list list not found: src

++ Executing suite spec/supply_converter_spec.lua◌
++ Executing suite spec/tools_compatibility_spec.lua⭆ Starting test set tools_compatibility_spec.lua:11 ⯈ Technic power tool compatibility
W:	Deprecated technic.register_power_tool use. Setting max_charge for oldlegacy:powertool
W:	Deprecated technic.register_power_tool use. Setting max_charge for oldminimal:powertool
W:	Deprecated technic.register_power_tool use. Setting max_charge for oldhalfway:powertool
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded
W:	Deprecated technic.register_power_tool use. Ensuring fields for oldlegacy:powertool
W:	Using metadata charge values for oldlegacy:powertool
W:	Updated legacy Technic power tool definition for oldlegacy:powertool
W:	Deprecated technic.register_power_tool use. Ensuring fields for oldminimal:powertool
W:	Using metadata charge values for oldminimal:powertool
W:	Updated legacy Technic power tool definition for oldminimal:powertool
W:	Deprecated technic.register_power_tool use. Ensuring fields for oldhalfway:powertool
W:	Mod oldhalfway seems to be aware of technic.plus but oldhalfway:powertool is still using deprecated registration, skipping meta charge compatibility.
W:	Updated legacy Technic power tool definition for oldhalfway:powertool
🢆 Running tests from tools_compatibility_spec.lua:92 ▷ Technic power tool compatibility oldlegacy:powertool can be used (minimum charge)
W:	Use of deprecated function technic.set_RE_wear with stack: oldlegacy:powertool
🢆 Running tests from tools_compatibility_spec.lua:106 ▷ Technic power tool compatibility oldlegacy:powertool can be used (minimum charge + 1)
W:	Use of deprecated function technic.set_RE_wear with stack: oldlegacy:powertool
🢆 Running tests from tools_compatibility_spec.lua:92 ▷ Technic power tool compatibility oldminimal:powertool can be used (minimum charge)
W:	Use of deprecated function technic.set_RE_wear with stack: oldminimal:powertool
🢆 Running tests from tools_compatibility_spec.lua:106 ▷ Technic power tool compatibility oldminimal:powertool can be used (minimum charge + 1)
W:	Use of deprecated function technic.set_RE_wear with stack: oldminimal:powertool

++ Executing suite spec/tools_spec.lua⭆ Starting test set tools_spec.lua:13 ⯈ Technic power tool
W:	Unsupported registration overrides detected for core.registered_on_mods_loaded
🢆 Running tests from tools_spec.lua:418 ▷ Technic power tool Prospector new item can be used
SX	�(T@technic)Right-click to set target block type�E
🢆 Running tests from tools_spec.lua:445 ▷ Technic power tool Prospector charge is used
SX	�(T@technic)�Fstone description�E is present in �F1x1x7�E region�E

242 successes / 1 failure / 0 errors / 4 pending : 22.735318 seconds

Pending → spec/api_spec.lua @ 138
Technic API Machine registration registers my_mod:my_battery
spec/api_spec.lua:138: Battery box registration does not include all fields

Pending → spec/api_spec.lua @ 195
Technic API Machine registration registers my_mod:machine_base
spec/api_spec.lua:195: Base machine registration does not include all fields

Pending → spec/api_spec.lua @ 290
Technic API internals technic.cables TBD, misleading name and should be updated
spec/api_spec.lua:290: TBD technic.cables naming and need, see technic networks data for possible options

Pending → spec/supply_converter_spec.lua @ 78
Supply converter building overloads network
spec/supply_converter_spec.lua:78: overload does not work with supply converter

Failure → spec/api_spec.lua @ 42
Technic API Machine registration registers my_mod:my_solar_array
spec/api_spec.lua:86: Expected objects to be equal.
Passed in:
(table: 0x7fcb16ba14f0) { }
Expected:
(table: 0x7fcb16ad8800) { }

@S-S-X S-S-X merged commit cc0a62a into master Feb 26, 2025
4 of 6 checks passed
@S-S-X S-S-X deleted the Fix-badges branch February 26, 2025 21:03
@S-S-X
Copy link
Member Author

S-S-X commented Feb 26, 2025

Reverted mtt, my best understanding after going through things around it was that it doesn't really do much with CNC or chests.
And it wasn't there before this PR or before first approval.
Changes done after approval were technically same that were approved for main README.md, just fixed those very same issues in CNC & chests README files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants