fix(sql_database): gracefully handle empty or unserializable query#70
Merged
mta-edi-sugiarto merged 1 commit intomainfrom Sep 28, 2025
Merged
Conversation
…sults The SQL query execution method previously returned an empty string for queries that yielded no results. This could lead to ambiguity and potential errors in services consuming this output. This change ensures the method consistently returns a string representation of an empty list (`"[]"`) in the following cases: - The query returns no rows. - The query result is empty after fetching. - An error occurs during result serialization. This provides a more predictable and robust interface for consumers.
mta-edi-sugiarto
deleted the
fix(sql_generation)/fix-sql-error-on-zero-entries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL query execution method previously returned an empty string for queries that yielded no results. This could lead to ambiguity and potential errors in services consuming this output.
This change ensures the method consistently returns a string representation of an empty list (
"[]") in the following cases:This provides a more predictable and robust interface for consumers.