Skip to content

Dynamic Favicon shows number of new lines#22

Merged
mthenw merged 5 commits intomthenw:masterfrom
lexx27:favicon
Jan 10, 2014
Merged

Dynamic Favicon shows number of new lines#22
mthenw merged 5 commits intomthenw:masterfrom
lexx27:favicon

Conversation

@lexx27
Copy link
Copy Markdown
Contributor

@lexx27 lexx27 commented Nov 1, 2013

I tried to achieve this with minimum dependencies.
I used tinyconjs for the favicon manipulation but I avoided to use jquery just for the focus event.

Comment thread lib/web/assets/app.js
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move those 3 line to new method _updateFavicon

@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Nov 3, 2013

I've tested this PR and looks line bubble with counter appears when window is foused. Is this correctly?

@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Nov 6, 2013

Do you need some help here?

@lexx27
Copy link
Copy Markdown
Contributor Author

lexx27 commented Nov 6, 2013

Hey! Thanks for asking. No, I got this. This week is a little busy for me that why I didn't do anything here.

The idea is to update the favicon counter while you are not on the fronttail tab.When you switch on the tab, the favicon counter resets...

I also plan to add a separator before the "new" lines so that a user be able to quickly understand where the updates start

@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Nov 6, 2013

Ok, so I waiting for any news.

Separator is very usable idea :)

@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Jan 4, 2014

Any news? :)

@lexx27
Copy link
Copy Markdown
Contributor Author

lexx27 commented Jan 10, 2014

Not yet, sorry

But I will soon do something about it :)

@mthenw mthenw merged commit 5508492 into mthenw:master Jan 10, 2014
@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Jan 10, 2014

I hope you don't mind that I fixed above issues merged to master :)

@lexx27
Copy link
Copy Markdown
Contributor Author

lexx27 commented Jan 10, 2014

No I don't mind. Οn the contrary I am very relieved :D

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants