Dynamic Favicon shows number of new lines#22
Conversation
There was a problem hiding this comment.
Please move those 3 line to new method _updateFavicon
|
I've tested this PR and looks line bubble with counter appears when window is foused. Is this correctly? |
|
Do you need some help here? |
|
Hey! Thanks for asking. No, I got this. This week is a little busy for me that why I didn't do anything here. The idea is to update the favicon counter while you are not on the fronttail tab.When you switch on the tab, the favicon counter resets... I also plan to add a separator before the "new" lines so that a user be able to quickly understand where the updates start |
|
Ok, so I waiting for any news. Separator is very usable idea :) |
|
Any news? :) |
|
Not yet, sorry But I will soon do something about it :) |
|
I hope you don't mind that I fixed above issues merged to master :) |
|
No I don't mind. Οn the contrary I am very relieved :D Thanks! |
I tried to achieve this with minimum dependencies.
I used tinyconjs for the favicon manipulation but I avoided to use jquery just for the focus event.