Make handlers depend on sqlite.Store directly#490
Merged
Conversation
The handlers package already depends on narrower interfaces for the components that need abstraction, such as authentication, sessions, metadata lookup, and password reset. The extra handlers.Store interface does not create a meaningful seam on top of those abstractions because the only concrete store in use is sqlite.Store. Depending on sqlite.Store directly removes a large duplicate interface definition, keeps the existing tighter interfaces intact, and makes the code reflect the real dependency graph more accurately. This also matches the direction taken in 0779737 without pulling in the broader session-store changes from that commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handlers package already depends on narrower interfaces for the components that need abstraction, such as authentication, sessions, metadata lookup, and password reset. The extra handlers.Store interface does not create a meaningful seam on top of those abstractions because the only concrete store in use is sqlite.Store.
Depending on sqlite.Store directly removes a large duplicate interface definition, keeps the existing tighter interfaces intact, and makes the code reflect the real dependency graph more accurately.