Fix "archive" script > compat with space in headers "service_id, monday, ..."

[mmathieum]

No description provided.

[gemini-code-assist]

Code Review

This pull request improves quoting and modifies the field separator (IFS) when parsing GTFS headers in archive.sh. The reviewer recommends avoiding a useless use of cat by passing the file directly to sed. Additionally, the reviewer advises against mixing whitespace and non-whitespace characters in IFS (i.e., IFS=", "), suggesting instead to strip spaces from the header line using tr and keeping IFS="," to prevent fragile splitting behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors shared-opt-dir/agency-parser/archive.sh by removing a redundant cat command and stripping carriage returns and spaces from the headers of calendar files. The review feedback correctly points out that while spaces are now stripped from the headers, the actual data extraction steps still only strip carriage returns. This discrepancy can leave leading spaces in the extracted dates, potentially causing malformed filenames and breaking downstream integer comparisons. It is recommended to also strip spaces from the extracted date values as suggested.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors shared-opt-dir/agency-parser/archive.sh to optimize file reading, improve console output formatting, and strip spaces and carriage returns from headers and dates. The review feedback suggests replacing a non-portable sed command with a more efficient and portable grep alternative to count non-empty lines, and combining multiple tr commands in pipelines into a single invocation to reduce process overhead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors shared-opt-dir/agency-parser/archive.sh to optimize file line counting using grep -c instead of cat, sed, and wc. It also improves string trimming by removing trailing spaces along with carriage returns, and wraps file names in single quotes in output messages. Feedback was provided to append || true to the grep -c command to prevent script termination under set -e when no matching lines are found.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors shared-opt-dir/agency-parser/archive.sh to optimize file line counting using grep instead of cat | sed | wc, and updates header/date parsing to strip spaces along with carriage returns. Feedback suggests defaulting FILE_CALENDAR_LINE to 0 to prevent a potential bash syntax error if grep fails or returns an empty string.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the archive.sh script to optimize file parsing and improve string trimming. It replaces a verbose pipeline for counting non-empty lines with a more efficient grep -c command, reorders command pipelines to cut fields before trimming, and updates carriage return removal to also strip spaces. The reviewer suggested a more concise and idiomatic way to assign FILE_CALENDAR_LINE using the || operator.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors shared-opt-dir/agency-parser/archive.sh to improve file parsing, specifically updating how line counts are determined and how carriage returns and spaces are stripped from headers and date fields. The review feedback focuses on performance optimizations: replacing external calls to head and tr with pure Bash parameter expansion for reading headers, and consolidating pipelines of tail, cut, and tr into single awk commands to reduce process-spawning overhead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the archive.sh script to optimize file reading and string manipulation, such as replacing external commands like cat, sed, and head with more efficient shell built-ins and grep. However, a critical bug was introduced in the calendar_dates.txt processing block where the population of HEADERS_ARRAY was accidentally removed, which will cause the script to fail. Additionally, a redundant assignment to HEADERS remains in that same block.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.