Generate brand new store release notes when missing.

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the store release notes generation mechanism within the MGenerator class. The primary improvement is the introduction of logic to create new release note files when they are missing, rather than solely updating pre-existing ones. This change ensures that the application can consistently generate and manage store release notes, improving the robustness of the release process.

Highlights

• Method Renaming: The dumpStoreListing method was renamed to dumpStoreReleaseNotes to more accurately reflect its function of handling release notes.
• New Release Note Generation: Implemented logic to generate brand new store release note files (for both English and French locales) if they do not already exist, ensuring comprehensive coverage for new releases.
• Improved File Handling: Enhanced the process for handling store release note files, including explicit directory creation and clearer logging for file generation and updates.

Changelog

• src/main/java/org/mtransit/parser/mt/MGenerator.java
  • Renamed the dumpStoreListing method to dumpStoreReleaseNotes for improved clarity.
  • Implemented functionality to generate new store release notes files if they are not found, ensuring that release notes are always present.
  • Updated file path construction to include a new listings directory.
  • Added logging for directory creation and new file generation events.
  • Introduced a new constant LISTINGS for directory path construction.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the store listing generation to create new release notes files if they are missing. While the intent is good, I've found a significant bug in the new logic for the French locale due to a copy-paste error, which would cause files to be written to the wrong directory. I've provided a fix for this. Additionally, I've pointed out that the bug is a symptom of significant code duplication between the English and French locale handling, and I've recommended a refactoring to improve maintainability and prevent such bugs in the future.

[mmathieum]

/gemini review

[Copilot]

Pull request overview

Extracts Play Store release notes generation into a dedicated generator and adds the ability to create new default.txt release notes when missing.

Changes:

• Added MStoreListingGenerator (Kotlin) to update or generate release notes for en-US and fr-FR.
• Updated MGenerator.dumpFiles() to call the new release-notes generator.
• Adjusted MGenerator.DATE_FORMAT visibility to be referenced by the new Kotlin generator.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
src/main/java/org/mtransit/parser/mt/MStoreListingGenerator.kt	New Kotlin generator that updates or creates Play Store release notes based on schedule dates.
src/main/java/org/mtransit/parser/mt/MGenerator.java	Hooks release-notes generation into the dump flow and refactors/removes the previous inlined implementation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request refactors the store release notes generation logic from MGenerator.java into a new Kotlin file, MStoreListingGenerator.kt. The new implementation also adds the functionality to generate new release notes files if they are missing. The refactoring is a good improvement. I have found a couple of critical issues in the new Kotlin file that will prevent compilation, related to invalid string syntax. I have also suggested a refactoring to reduce code duplication in the new file.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the store release notes generation by moving the logic from MGenerator.java to a new MStoreListingGenerator.kt class. This is a good change that improves code organization and leverages Kotlin. A new feature to generate release notes files from scratch if they are missing is also included. My review includes a critical fix for a syntax error in the new Kotlin file that would prevent compilation, and a medium-severity suggestion to improve encapsulation between the two modified files.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the store release notes generation into a new Kotlin class, MStoreListingGenerator, and updates date formatting to be more thread-safe by removing deprecated, non-thread-safe SimpleDateFormat instances. The new logic also correctly generates new release notes files if they are missing, which aligns with the pull request's goal. While the refactoring is a good step, the new implementation introduces a few issues: a compilation error due to invalid syntax in string constants, potential file corruption from not specifying a character set, and a remaining thread-safety issue with a static SimpleDateFormat instance. I've added specific comments with suggestions to address these points.