JSON configs > add stop_name_cleaners, (exclude|keep)_routes & compat w/ mtransitapps/commons-java#22

[mmathieum]

• Strings cleaner > remove Line/Station auto commons-java#22

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new JSON configuration option for defining custom stop name cleaning rules, enhancing the flexibility of how stop names are processed. It also updates existing string cleaning methods across route long names, trip headsigns, and stop names to include the agency route type, ensuring seamless compatibility with recent updates in the commons-java library.

Highlights

• New Configuration for Stop Name Cleaners: A new stop_name_cleaners configuration option has been added to RouteConfig.kt, allowing for custom, route-specific cleaning rules to be applied to stop names via JSON.
• Enhanced Stop Name Cleaning Logic: The cleanStopName method in DefaultAgencyTools.java now first applies the newly introduced route-specific stop_name_cleaners before proceeding with the default string cleaning process.
• Compatibility with commons-java Library: The cleanRouteLongName, cleanTripHeadsign, and cleanStopName methods in DefaultAgencyTools.java have been updated to pass the getAgencyRouteType() to the StringsCleaner utility, ensuring compatibility with recent changes in the mtransitapps/commons-java#22 library.

Changelog

• src/main/java/org/mtransit/parser/DefaultAgencyTools.java
  • Updated cleanRouteLongName to pass the agency route type to StringsCleaner.
  • Updated cleanTripHeadsign to pass the agency route type to StringsCleaner.
  • Modified cleanStopName to first apply route configuration specific cleaners and then pass the agency route type to StringsCleaner.
• src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt
  • Added stop_name_cleaners configuration property.
  • Implemented cleanStopName function to apply configured stop name cleaners.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new configuration option, stop_name_cleaners, to allow cleaning stop names via JSON configuration. It also updates several method calls for compatibility with mtransitapps/commons-java#22. The implementation looks good, but as noted in the review comment, adding tests for the new feature would improve maintainability.