Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #338, add option for connection options in HANA dialect #346

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@ariel-bentu
Copy link
Contributor

commented Aug 28, 2019

Describe here what is this PR about and what we are achieving merging this.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have wrote a description of what is the purpose of this pull request above

fix #338

Ariel Bentolila and others added 2 commits Aug 28, 2019
@mtxr
mtxr approved these changes Aug 28, 2019

@mtxr mtxr merged commit 87d45dc into mtxr:master Aug 28, 2019

1 of 3 checks passed

Mergeable Mergeable run returned Status ***FAIL***
Details
Travis CI - Pull Request Build Failed
Details
codeclimate All good!
Details
@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 28, 2019

Thanks @ariel-bentu ! Awesome!

@mtxr mtxr added this to In progress in Kanban via automation Aug 28, 2019

@mtxr mtxr moved this from In progress to To be released in Kanban Aug 28, 2019

@offer8

This comment has been minimized.

Copy link

commented Aug 31, 2019

Thanks for the fix! in which version of vscode-sqltools this will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.