Skip to content

Conversation

@ariel-bentu
Copy link
Contributor

@ariel-bentu ariel-bentu commented Aug 28, 2019

Describe here what is this PR about and what we are achieving merging this.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have wrote a description of what is the purpose of this pull request above

fix #338

@mtxr mtxr merged commit 87d45dc into mtxr:master Aug 28, 2019
@mtxr
Copy link
Owner

mtxr commented Aug 28, 2019

Thanks @ariel-bentu ! Awesome!

@offer8
Copy link

offer8 commented Aug 31, 2019

Thanks for the fix! in which version of vscode-sqltools this will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement sap SAP HANA driver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAP HANA connection fails

3 participants