Skip to content

Conversation

@peternowee
Copy link
Contributor

Prevents error:

dispatcher_1  | == Compilation error in file lib/dispatcher.ex ==
dispatcher_1  | ** (CompileError) lib/dispatcher.ex:12: undefined function layers/1

Prevents error:

    dispatcher_1  | == Compilation error in file lib/dispatcher.ex ==
    dispatcher_1  | ** (CompileError) lib/dispatcher.ex:12: undefined function layers/1
@nvdk
Copy link
Member

nvdk commented Sep 11, 2023

I think this was resolved by bumping the dispatcher version, where it does seem to be "layers". Can you confirm @peternowee ?

@peternowee
Copy link
Contributor Author

Sorry, cannot confirm.

I actually tested latest from Docker Hub already, which I assume is git latest as well. I tested on 2023-07-20 with https://hub.docker.com/layers/semtech/mu-dispatcher/latest/images/sha256-e181462ec4793cc025e0d23bd140a38d3b25d954bc9164a372827cb23c57dd85 which was and still is semtech/mu-dispatcher:latest on Docker Hub. I do not know to quickly see what git commit that Docker image is based on, but given that it was pushed 2023-05-15 14:24, I assumed it was based on mu-semtech/mu-dispatcher@c12bed5 of 2023-05-15 14:23, which was and currently still is the latest commit in mu-dispatcher branch master.

I also tested with semtech/mu-dispatcher:2.1.0-beta.2.

Result was the same in both cases: config/dispatcher/dispatcher.ex in mu-project needed to call define_layers instead of layers to prevent the error.

The only other active branch in mu-dispatcher at the moment is feature/arm64-build, which is now at mu-semtech/mu-dispatcher@45daeed of 2023-06-23, 2 commits ahead of master. But the changes there are not related to layers.

Other branches are stale and much older.

Searching the actual code for layers OR define_layers, the only relevant source code file seems to be lib/matcher.ex. I do not know Elixir very well, but lines 300-307 defmacro define_layers(layers). There are several occurrences of layers, but I am not sure if they are like public or private, but many seem more private/internal.

Just let me know if I need to test more.

@peternowee
Copy link
Contributor Author

peternowee commented Sep 11, 2023

In addition: The mu-dispatcher README also says define_layers.

@nvdk nvdk merged commit c0d3046 into mu-semtech:feature/add-auth Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants