Fix Metal training: use f32 tensors in microgpt#1010
Merged
Conversation
Metal's index_select kernel doesn't support the U32×F64 combination, causing "Metal contiguous index_select U32 F64 not implemented" at training time. Switch all candle tensor creation to f32 while keeping the JSON weight format compatible (f64) for InferenceGpt interop. Bump microgpt CLI to 0.2.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Chat history was initialized empty, but training data always starts with BOS. Without it, position embeddings are shifted and the model produces garbage. Prepend BOS on init and after /clear. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metal contiguous index_select U32 F64 not implementederror on Apple GPUTest plan
cargo test -p microgpt)microgpt train --device metalruns without error🤖 Generated with Claude Code