one_d4: add reanalysis unit/e2e tests and pin detector game position tests#1078
Merged
one_d4: add reanalysis unit/e2e tests and pin detector game position tests#1078
Conversation
…tests - AdminControllerTest: 9 unit tests covering batch processing, null/blank PGN handling, exception isolation, and store method call verification - GameFeatureDaoTest: 11 new tests for fetchForReanalysis (pagination, ordering) and updateMotifs (direct flags + derived has_discovered_attack, has_checkmate, has_discovered_mate from ATTACK occurrences) - ReanalysisE2ETest: 6 E2E tests — idempotency, occurrence replacement (stale occurrence removed after reanalyze), no-detector teardown, multi-game batch - PinDetectorTest: 3 King's Gambit move-4 FEN tests verifying Bb5→nc6 absolute pin fields and confirming no false-positive extra pins - BUILD: add AdminControllerTest to api_validation_tests (+:engine dep), add ReanalysisE2ETest to e2e_tests (+:model dep)
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 855f9c8 | Commit Preview URL Branch Preview URL |
Feb 28 2026, 06:14 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /admin/reanalyzebatching loop — null/blank PGN counted as failed, exceptions on individual games don't abort others, store methods (updateMotifs,deleteOccurrencesByGameUrl,insertOccurrences) called in the right orderfetchForReanalysispagination/ordering +updateMotifsincluding the three derived columns (has_discovered_attack,has_checkmate,has_discovered_mate) derived from ATTACK occurrences'isDiscovered/isMateflags4.Bb5) with exact attacker/target assertions; regression guard confirming exactly one pin detected in that position (no false positives)AdminControllerTestadded toapi_validation_tests(+:enginedep);ReanalysisE2ETestadded toe2e_tests(+:modeldep)Test plan
bazel test //domains/games/apis/one_d4:api_validation_tests— 29 passbazel test //domains/games/apis/one_d4:db_tests— passbazel test //domains/games/apis/one_d4:motifs_tests— passbazel test //domains/games/apis/one_d4:e2e_tests— pass